no1wudi opened a new pull request, #8950:
URL: https://github.com/apache/nuttx/pull/8950

   
   
   ## Summary
   If TELNET_CHARACTER_MODE is set, the ECHO must be handled by the telnet 
server.
   
   So this option is useless. We need a new approach to control the ECHO 
behavior.
   
   BTW,  I prefer to implement TERMIOS for telnet driver,  and then we can 
merge the `nsh_login.c` and 'nsh_telnetlogin.c' into one.
   
   ## Impact
   telnel driver only
   ## Testing
   CI and custom boards
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to