xiaoxiang781216 commented on PR #8940:
URL: https://github.com/apache/nuttx/pull/8940#issuecomment-1494664613

   > Changing this API is not OK. It breaks systems that pass the value 
CONFIG_BOARD_ASSERT_RESET_VALUE to mean s something. 0 reboot, 1 boot to ROM... 
etc
   > 
   
   > Once before this was changed: the default was moved from 0 to 1. That 
broke all code using the value.
   
   But, the default value is 1 not 0:
   
https://github.com/apache/nuttx/pull/8940/files#diff-60cc096e3a9b22a769602cbbc3b0f5e7731e72db7b0338da04fcf665ed753b64L4064
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to