[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8951: sched/semaphore: optimize semaphore holder check for priority inheritance

[via GitHub]

xiaoxiang781216 commented on code in PR #8951:
URL: https://github.com/apache/nuttx/pull/8951#discussion_r1157655350


##########
sched/semaphore/sem_holder.c:
##########
@@ -102,21 +102,17 @@ nxsem_allocholder(FAR sem_t *sem, FAR struct tcb_s *htcb)
   else
     {
       serr("ERROR: Insufficient pre-allocated holders\n");
-      pholder          = NULL;
-      DEBUGPANIC();
+      PANIC();
     }
 
-  if (pholder != NULL)
-    {
-      pholder->sem    = sem;
-      pholder->htcb   = htcb;
-      pholder->counts = 0;
+  pholder->sem    = sem;

Review Comment:
   remove the extra sapce before = from line 88-99



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org