xiaoxiang781216 commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1158052306
########## Makefile: ########## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all) +$(BIN): $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_romloader) $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all) Review Comment: In this case, the user could do the generation in context target just like how we deal with the 3rd party libraries. I found that context phase is a best place to resolve the cross project dependence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
