fjpanag commented on PR #8970: URL: https://github.com/apache/nuttx/pull/8970#issuecomment-1497579422
> @xiaoxiang781216 this change is needed as a side effect of #8938 that calls `gettid` from `nxsem_post` -> `nxsem_checkholder`. So `kmm_free(g_pidhash);` calls `nxsem_post` that is accessing `g_pidhash` that is already freed despite the critical section. I think this change can go it only after #8951 is merged, so we do not access `g_pidhash` from `nxsem_post` Even if #8951 is merged, I think this change shall be kept. It is the correct think to do. What is the actual problem the fix creates? Maybe we can solve the new problem, not re-introduce a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
