yamt commented on code in PR #8997:
URL: https://github.com/apache/nuttx/pull/8997#discussion_r1162478514
##########
arch/sim/src/sim/win/sim_hostfs.c:
##########
@@ -120,6 +120,11 @@ int host_open(const char *pathname, int flags,
nuttx_mode_t mode)
mapflags |= O_TRUNC;
}
+ if (flags & NUTTX_O_BINARY)
+ {
+ mapflags |= O_BINARY;
+ }
Review Comment:
* have you tested this? the definition of `NUTTX_O_BINARY` has been broken
since https://github.com/apache/nuttx/pull/6357 it seems.
* why don't you always use O_BINARY for the host? afaik nuttx doesn't really
have text mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
