xiaoxiang781216 commented on code in PR #8985:
URL: https://github.com/apache/nuttx/pull/8985#discussion_r1164328463
##########
drivers/pipes/pipe_common.c:
##########
@@ -105,6 +105,8 @@ FAR struct pipe_dev_s *pipecommon_allocdev(size_t bufsize)
nxmutex_init(&dev->d_bflock);
nxsem_init(&dev->d_rdsem, 0, 0);
nxsem_init(&dev->d_wrsem, 0, 0);
+ nxsem_init(&dev->d_nrdsem, 0, 0);
+ nxsem_init(&dev->d_nwrsem, 0, 0);
Review Comment:
since the old design reuse rdsem, I would prefer that we follow the original
design to minimize the code change. If you think the separation, make the code
clean, it's better to do the refactor in a new patch either before or after
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
