xiaoxiang781216 commented on code in PR #9022: URL: https://github.com/apache/nuttx/pull/9022#discussion_r1165808392
########## libs/libc/string/lib_strnlen.c: ########## @@ -30,7 +30,8 @@ * Public Functions ****************************************************************************/ -#ifndef CONFIG_LIBC_ARCH_STRNLEN +#if !defined(CONFIG_LIBC_ARCH_STRNLEN) && \ Review Comment: why not remove CONFIG_LIBC_ARCH_STRNLEN check directly? lib_strnlen.c is already skipped in Makefile if CONFIG_LIBC_ARCH_STRNLEN equals y, which make the check redundancy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
