davids5 commented on code in PR #8743: URL: https://github.com/apache/nuttx/pull/8743#discussion_r1172275393
########## include/semaphore.h: ########## @@ -113,7 +113,7 @@ struct sem_s # if CONFIG_SEM_PREALLOCHOLDERS > 0 FAR struct semholder_s *hhead; /* List of holders of semaphore counts */ # else - struct semholder_s holder[2]; /* Slot for old and new holder */ + struct semholder_s holder; /* Slot for old and new holder */ Review Comment: This did not work in the past. Please review the comments in commit that added `struct semholder_s holder[2]; /* Slot for old and new holder */` and ensure that the reason the 2 slots were needed has been changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
