xiaoxiang781216 commented on code in PR #9066:
URL: https://github.com/apache/nuttx/pull/9066#discussion_r1174493975


##########
libs/libc/pthread/pthread_barrierwait.c:
##########
@@ -90,14 +91,14 @@ int pthread_barrier_wait(FAR pthread_barrier_t *barrier)
 
   /* Disable pre-emption throughout the following */
 
-  sched_lock();
+  flags = enter_critical_section();

Review Comment:
   libc can't call enter_critical_section directly since enter_critical_section 
belong to kernel space. we need either move the source code to sched/ or add 
mutex.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to