pkarashchenko commented on PR #9151:
URL: https://github.com/apache/nuttx/pull/9151#issuecomment-1531596040
> > > These memory management function changes would set the `errno`. So
when these memory management functions are called from the OS, the `errno` may
be trashed. Kernel logic must never modifiy the `errno` value per Issue #1027.
> > > In order to make this change, the memory management subsystem
architecture will need to be modified to permit OS access to the allocators
without modifying the `errno`. For example, perhaps there is an` nx_realloc()`,
for example, that is called from `mm_realloc()` like:
> > > ```
> > > mem = nx_realloc(USR_HEAP, alignment, size);
> > > if (!mem)
> > > {
> > > set_errno(ENOMEM);
> > > }
> > > ```
> >
> >
> > I will revert errno changes and keep only zero-allocation logic, so
`errno` compliance will be handled in a separate change
>
> I think set_errno could move into malloc/calloc.
I places set_errno into malloc/calloc only, but I think @patacongo is
talking about FLAT build where kernel allocations are remapped to
`malloc/calloc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
