pkarashchenko commented on PR #9151: URL: https://github.com/apache/nuttx/pull/9151#issuecomment-1531818506
> > @patacongo @xiaoxiang781216 should we remove `set_errno(errcode);` from `FAR void *sbrk(intptr_t incr)` implementation for now until we fix the #1027 and add corresponding wrappers of allocation API in case of FLAT mode? > > but I think that it's right to set_errno in sbrk. We only need add a new patch which: > > 1. Separate the implementation kmm_malloc from malloc even for FLAT mode > 2. Call set_errno inside malloc/calloc if needed It is the same level as setting errno from malloc/calloc/realloc now, so I do not see the reason why we should handle those in a different way now. But let's move step by step -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
