[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9040: [SYSLOG] avoid concurrent modification by other tasks

[via GitHub]

xiaoxiang781216 commented on code in PR #9040:
URL: https://github.com/apache/nuttx/pull/9040#discussion_r1186039297


##########
drivers/syslog/syslog_write.c:
##########
@@ -62,6 +62,13 @@ static ssize_t syslog_default_write(FAR const char *buffer, 
size_t buflen)
 
   if (up_interrupt_context() || sched_idletask())
     {
+#ifdef CONFIG_SYSLOG_INTBUFFER
+      if (up_interrupt_context())
+        {
+          sched_lock();

Review Comment:
   but sched_lock can't use to protect the shared resource in SMP case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org