fjpanag opened a new issue, #1745:
URL: https://github.com/apache/nuttx-apps/issues/1745

   Quite recently, building NSH provides me with the following warnings:
   
   ```
   nshlib/nsh_proccmds.c: In function ‘ps_callback’:
   nshlib/nsh_proccmds.c:357:1: warning: embedding a directive within macro 
arguments is not portable
     357 | #ifdef CONFIG_SMP
         | ^
   nshlib/nsh_proccmds.c:359:1: warning: embedding a directive within macro 
arguments is not portable
     359 | #endif
         | ^
   nshlib/nsh_proccmds.c:363:1: warning: embedding a directive within macro 
arguments is not portable
     363 | #ifdef CONFIG_SMP
         | ^
   nshlib/nsh_proccmds.c:365:1: warning: embedding a directive within macro 
arguments is not portable
     365 | #endif
         | ^
   nshlib/nsh_proccmds.c:532:1: warning: embedding a directive within macro 
arguments is not portable
     532 | #ifdef PS_SHOW_HEAPSIZE
         | ^
   nshlib/nsh_proccmds.c:534:1: warning: embedding a directive within macro 
arguments is not portable
     534 | #endif
         | ^
   nshlib/nsh_proccmds.c:535:1: warning: embedding a directive within macro 
arguments is not portable
     535 | #ifdef PS_SHOW_STACKSIZE
         | ^
   nshlib/nsh_proccmds.c:537:1: warning: embedding a directive within macro 
arguments is not portable
     537 | #endif
         | ^
   nshlib/nsh_proccmds.c:538:1: warning: embedding a directive within macro 
arguments is not portable
     538 | #ifdef PS_SHOW_STACKUSAGE
         | ^
   nshlib/nsh_proccmds.c:541:1: warning: embedding a directive within macro 
arguments is not portable
     541 | #endif
         | ^
   nshlib/nsh_proccmds.c:542:1: warning: embedding a directive within macro 
arguments is not portable
     542 | #ifdef NSH_HAVE_CPULOAD
         | ^
   nshlib/nsh_proccmds.c:544:1: warning: embedding a directive within macro 
arguments is not portable
     544 | #endif
         | ^
   nshlib/nsh_proccmds.c:545:1: warning: embedding a directive within macro 
arguments is not portable
     545 | #if CONFIG_MM_BACKTRACE >= 0 && 
!defined(CONFIG_NSH_DISABLE_PSHEAPUSAGE)
         | ^
   nshlib/nsh_proccmds.c:547:1: warning: embedding a directive within macro 
arguments is not portable
     547 | #endif
         | ^
   nshlib/nsh_proccmds.c:548:1: warning: embedding a directive within macro 
arguments is not portable
     548 | #if !defined(CONFIG_NSH_DISABLE_PSSTACKUSAGE)
         | ^
   nshlib/nsh_proccmds.c:550:1: warning: embedding a directive within macro 
arguments is not portable
     550 | #endif
         | ^
   nshlib/nsh_proccmds.c:551:1: warning: embedding a directive within macro 
arguments is not portable
     551 | #ifdef PS_SHOW_STACKUSAGE
         | ^
   nshlib/nsh_proccmds.c:556:1: warning: embedding a directive within macro 
arguments is not portable
     556 | #endif
         | ^
   nshlib/nsh_proccmds.c:557:1: warning: embedding a directive within macro 
arguments is not portable
     557 | #ifdef NSH_HAVE_CPULOAD
         | ^
   nshlib/nsh_proccmds.c:559:1: warning: embedding a directive within macro 
arguments is not portable
     559 | #endif
         | ^
   nshlib/nsh_proccmds.c: In function ‘cmd_ps’:
   nshlib/nsh_proccmds.c:626:1: warning: embedding a directive within macro 
arguments is not portable
     626 | #ifdef CONFIG_SMP
         | ^
   nshlib/nsh_proccmds.c:628:1: warning: embedding a directive within macro 
arguments is not portable
     628 | #endif
         | ^
   nshlib/nsh_proccmds.c:631:1: warning: embedding a directive within macro 
arguments is not portable
     631 | #if CONFIG_MM_BACKTRACE >= 0 && 
!defined(CONFIG_NSH_DISABLE_PSHEAPUSAGE)
         | ^
   nshlib/nsh_proccmds.c:633:1: warning: embedding a directive within macro 
arguments is not portable
     633 | #endif
         | ^
   nshlib/nsh_proccmds.c:634:1: warning: embedding a directive within macro 
arguments is not portable
     634 | #if !defined(CONFIG_NSH_DISABLE_PSSTACKUSAGE)
         | ^
   nshlib/nsh_proccmds.c:636:1: warning: embedding a directive within macro 
arguments is not portable
     636 | #ifdef CONFIG_STACK_COLORATION
         | ^
   nshlib/nsh_proccmds.c:639:1: warning: embedding a directive within macro 
arguments is not portable
     639 | #endif
         | ^
   nshlib/nsh_proccmds.c:640:1: warning: embedding a directive within macro 
arguments is not portable
     640 | #endif
         | ^
   nshlib/nsh_proccmds.c:641:1: warning: embedding a directive within macro 
arguments is not portable
     641 | #ifdef NSH_HAVE_CPULOAD
         | ^
   nshlib/nsh_proccmds.c:643:1: warning: embedding a directive within macro 
arguments is not portable
     643 | #endif
         | ^
   nshlib/nsh_proccmds.c:646:1: warning: embedding a directive within macro 
arguments is not portable
     646 | #ifdef CONFIG_SMP
         | ^
   nshlib/nsh_proccmds.c:648:1: warning: embedding a directive within macro 
arguments is not portable
     648 | #endif
         | ^
   nshlib/nsh_proccmds.c:651:1: warning: embedding a directive within macro 
arguments is not portable
     651 | #if CONFIG_MM_BACKTRACE >= 0 && 
!defined(CONFIG_NSH_DISABLE_PSHEAPUSAGE)
         | ^
   nshlib/nsh_proccmds.c:653:1: warning: embedding a directive within macro 
arguments is not portable
     653 | #endif
         | ^
   nshlib/nsh_proccmds.c:654:1: warning: embedding a directive within macro 
arguments is not portable
     654 | #if !defined(CONFIG_NSH_DISABLE_PSSTACKUSAGE)
         | ^
   nshlib/nsh_proccmds.c:656:1: warning: embedding a directive within macro 
arguments is not portable
     656 | #ifdef CONFIG_STACK_COLORATION
         | ^
   nshlib/nsh_proccmds.c:659:1: warning: embedding a directive within macro 
arguments is not portable
     659 | #endif
         | ^
   nshlib/nsh_proccmds.c:660:1: warning: embedding a directive within macro 
arguments is not portable
     660 | #endif
         | ^
   nshlib/nsh_proccmds.c:661:1: warning: embedding a directive within macro 
arguments is not portable
     661 | #ifdef NSH_HAVE_CPULOAD
         | ^
   nshlib/nsh_proccmds.c:663:1: warning: embedding a directive within macro 
arguments is not portable
     663 | #endif
         | ^
   ```
   
   I think it would be wise to fix these.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to