TimJTi commented on code in PR #9252: URL: https://github.com/apache/nuttx/pull/9252#discussion_r1194171277
########## include/nuttx/efuse/sama5_sfc_fuses.h: ########## @@ -0,0 +1,247 @@ +/**************************************************************************** + * include/nuttx/efuse/sama5_sfc_fuses.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_EFUSE_SAMA5_FUSES_H +#define __INCLUDE_NUTTX_EFUSE_SAMA5_FUSES_H + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#if defined(ATSAMA5D2) +#define SAM_SFC_EFUSE_MAX_LEN 544 /* Max length of sfc area. */ +#elif defined ATSAMA5D4 +#define SAM_SFC_EFUSE_MAX_LEN 512 /* Max length of sfc area. */ +#endif + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +/**************************************************************************** + * Type Definitions + ****************************************************************************/ + +#if defined(CONFIG_EFUSE) && defined(CONFIG_SAMA5_SFC) Review Comment: FYI @acassis said: > I think the efuse table currently is located at arch directory as you can see at arch/xtensa/src/esp32/esp32_efuse_table.c but there is an issue: an application is nuttx-apps/ normally cannot access files inside arch/. So I think the right place should be inside include/nuttx/efuse/ If I move that file to chip/src - or chip/src/hardware? - I will need to edit the comment that is then wrong in efuse.h then. OK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
