liqinhuixm commented on code in PR #9262: URL: https://github.com/apache/nuttx/pull/9262#discussion_r1194771645
########## net/tcp/tcp.h: ########## @@ -71,7 +71,7 @@ # define TCP_WBPKTLEN(wrb) ((wrb)->wb_iob->io_pktlen) # define TCP_WBSENT(wrb) ((wrb)->wb_sent) # define TCP_WBNRTX(wrb) ((wrb)->wb_nrtx) -#ifdef CONFIG_NET_TCP_FAST_RETRANSMIT +#if defined(CONFIG_NET_TCP_FAST_RETRANSMIT) && !defined(CONFIG_NET_TCP_CC_NEWRENO) # define TCP_WBNACK(wrb) ((wrb)->wb_nack) Review Comment: Given the independence of the Fast Retransmit and NewReno functions, the wb_nack needs to be temporarily reserved for use when only Fast Retransmit is enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
