ldube commented on code in PR #9287: URL: https://github.com/apache/nuttx/pull/9287#discussion_r1195572019
########## drivers/usbhost/usbhost_hub.c: ########## @@ -1491,7 +1521,7 @@ static int usbhost_disconnected(struct usbhost_class_s *hubclass) { Review Comment: @xiaoxiang781216 I think agree with you now and will not use the flag. I am beginning to question my approach. Doing this : CLASS_DISCONNECTED(child->devclass) does not free the other device types quickly. Only hubs are freed immediately. I have to do it your way: CLASS_DISCONNECTED(child->devclass, true) to make it clean. But all the other drivers will have to be modified so ... I am thinking of finding another way to fix the problem. I have done some testing and so far only hubs crash the system when their parent is freed first. After I find out why, I will decide how to fix this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org