no1wudi commented on code in PR #1761: URL: https://github.com/apache/nuttx-apps/pull/1761#discussion_r1197248351
########## tools/Wasm.mk: ########## @@ -24,7 +24,17 @@ include $(APPDIR)$(DELIM)interpreters$(DELIM)wamr$(DELIM)Toolchain.defs # wasi-sdk toolchain setting WCC ?= $(WASI_SDK_PATH)/bin/clang -WAR ?= $(WASI_SDK_PATH)/bin/llvm-ar rcs +WAR ?= $(WASI_SDK_PATH)/bin/llvm-ar Review Comment: Here is the first place, Wasm.mk is introduced by Application.mk. I think check it by toolchain is better, there is a case that enable a wasm interpreter but don't want to build wasm app from nuttx repo (some apps enabled WASM_BUILD by default). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
