patacongo commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1197831002
########## binfmt/builtin.c: ########## @@ -106,6 +106,12 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->entrypt = builtin->main; binp->stacksize = builtin->stacksize; binp->priority = builtin->priority; +#ifdef CONFIG_SCHED_USER_IDENTITY + binp->uid = builtin->uid; + binp->gid = builtin->gid; + binp->mode = builtin->mode; +#endif Review Comment: > I suppose this does not matter much right now since everything runs as root:root When the user logs into NSH, the UID and GID should be available in /etc/password. These should be used to set the session UID/GID sometime in the future. Then inheritance of the UID/GID would be more important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
