xiaoxiang781216 commented on code in PR #9331:
URL: https://github.com/apache/nuttx/pull/9331#discussion_r1199558244
##########
drivers/usbhost/usbhost_enumerate.c:
##########
@@ -51,7 +51,9 @@ static void usbhost_putle16(uint8_t *dest, uint16_t val);
static inline int usbhost_devdesc(const struct usb_devdesc_s *devdesc,
FAR struct usbhost_id_s *id);
static inline int usbhost_configdesc(const uint8_t *configdesc, int desclen,
- FAR struct usbhost_id_s *id);
+ const uint8_t start_ifnum,
Review Comment:
It's debatable whether the const non pointer parameters should be added
const or not, but the whole code base seldom(never?) add const to this type of
parameter. I am natural to add const or not for this case, but the same rule
must be applied universally to the whole code base. So I would suggest to
create a new PR to add const to all const parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
