xiaoxiang781216 commented on code in PR #9103:
URL: https://github.com/apache/nuttx/pull/9103#discussion_r1211030983


##########
arch/risc-v/src/common/riscv_macros.S:
##########
@@ -106,11 +106,6 @@
   and        t2, t0, t1
   li         t1, MSTATUS_FS_DIRTY
   bne        t2, t1, 1f

Review Comment:
   should we change to:
   ```
     li         t1, MSTATUS_FS_INIT
     ble        t2, t1, 1f
   ```



##########
arch/risc-v/src/common/riscv_macros.S:
##########
@@ -227,8 +222,8 @@
   REGLOAD      t0, REG_INT_CTX(\out)
   li           t1, MSTATUS_FS
   and          t2, t0, t1
-  li           t1, MSTATUS_FS_INIT
-  ble          t2, t1, 1f

Review Comment:
   Yes, I think so.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to