xiaoxiang781216 commented on code in PR #9297: URL: https://github.com/apache/nuttx/pull/9297#discussion_r1216596912
########## arch/risc-v/src/qemu-rv/Make.defs: ########## @@ -36,7 +36,3 @@ endif ifeq ($(CONFIG_MM_PGALLOC),y) CHIP_CSRCS += qemu_rv_pgalloc.c endif - -ifeq ($(CONFIG_DRIVERS_VIRTIO_NET),y) -CHIP_CSRCS += qemu_rv_virtio.c Review Comment: remove qemu_rv_virtio.c too ########## arch/arm64/src/qemu/Make.defs: ########## @@ -26,7 +26,3 @@ CHIP_CSRCS = qemu_boot.c qemu_serial.c ifeq ($(CONFIG_ARCH_EARLY_PRINT),y) CHIP_ASRCS = qemu_lowputc.S endif - -ifeq ($(CONFIG_DRIVERS_VIRTIO_NET),y) -CHIP_CSRCS += qemu_virtio.c Review Comment: let's remove emu_virtio.c too ########## drivers/virtio/virtio-serial.c: ########## @@ -0,0 +1,603 @@ +/**************************************************************************** + * drivers/virtio/virtio-serial.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <debug.h> +#include <errno.h> +#include <stdio.h> + +#include <nuttx/serial/serial.h> +#include <nuttx/virtio/virtio.h> + +#include "virtio-serial.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define VIRTIO_SERIAL_RX 0 +#define VIRTIO_SERIAL_TX 1 +#define VIRTIO_SERIAL_NUM 2 + +/**************************************************************************** + * Private Types + ****************************************************************************/ + +struct virtio_serial_priv_s +{ + /* Virtio device informations */ + + FAR struct virtio_device *vdev; + + /* Nuttx uart device informations */ + + FAR struct uart_dev_s udev; + char name[NAME_MAX]; + bool recving; Review Comment: remove the unused recving field -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
