patacongo commented on code in PR #9528:
URL: https://github.com/apache/nuttx/pull/9528#discussion_r1228414332
##########
sched/group/group_join.c:
##########
@@ -208,9 +218,12 @@ int group_join(FAR struct pthread_tcb_s *tcb)
{
return ret;
}
+#else
+ flags = enter_critical_section();
Review Comment:
As a general rule, spin_lock_irqsave() should always be used in preference
to enter_critical_section() provided that you can be assured that the thread
will never wait while holding the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
