patacongo commented on PR #9521: URL: https://github.com/apache/nuttx/pull/9521#issuecomment-1593319552
> @patacongo I think you were planing to reply @zhhyu7, but end up editing his comment, it was difficult to understand who said what. :-) Oops. Yes, I meant to Quote Reply, not Edit > Yes, I found some examples in wqueue.h, udp.h, etc. > > But I think in this case if fsid_s is planned to be used for all filesystems, eventually we will have a function that list fs based on fs IDs, etc. So in this case fsid_s could be passed as parameter to this function. > > Anyway we need to define the right place to put it Since it is non-standard, it belongs under include/nuttx somewhere, possibly in fs.h. NOTE: Other implementations do not use a structure and also define it differently for each file system. For example, https://elixir.bootlin.com/linux/latest/source/fs/ufs/ufs_fs.h#L406, https://elixir.bootlin.com/linux/latest/source/fs/ufs/ufs_fs.h#L857 Why are we introducing a non-standard spurious definition? It is not compatible in any usage. The definitions would always be accessed like: bla->fs_id[i] This structure definition is NOT compatible. It would require that the fields be accessed like: bla->fs_id.val[i] Let's just remove this incompatible structure. It should not be there or anywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
