CV-Bowen commented on code in PR #9297: URL: https://github.com/apache/nuttx/pull/9297#discussion_r1245266170
########## boards/arm64/qemu/qemu-armv8a/configs/netnsh/defconfig: ########## @@ -16,17 +16,25 @@ CONFIG_ARCH_CHIP_QEMU_A53=y CONFIG_ARCH_INTERRUPTSTACK=4096 CONFIG_BUILTIN=y CONFIG_CODECS_HASH_MD5=y +CONFIG_DEBUG_ASSERTIONS=y +CONFIG_DEBUG_ERROR=y +CONFIG_DEBUG_FEATURES=y CONFIG_DEBUG_FULLOPT=y +CONFIG_DEBUG_INFO=y CONFIG_DEBUG_SYMBOLS=y +CONFIG_DEBUG_VIRTIO=y Review Comment: Done ########## boards/arm64/qemu/qemu-armv8a/configs/netnsh/defconfig: ########## @@ -16,17 +16,25 @@ CONFIG_ARCH_CHIP_QEMU_A53=y CONFIG_ARCH_INTERRUPTSTACK=4096 CONFIG_BUILTIN=y CONFIG_CODECS_HASH_MD5=y +CONFIG_DEBUG_ASSERTIONS=y +CONFIG_DEBUG_ERROR=y +CONFIG_DEBUG_FEATURES=y CONFIG_DEBUG_FULLOPT=y +CONFIG_DEBUG_INFO=y CONFIG_DEBUG_SYMBOLS=y +CONFIG_DEBUG_VIRTIO=y +CONFIG_DEBUG_VIRTIO_ERROR=y +CONFIG_DEBUG_VIRTIO_WARN=y +CONFIG_DEBUG_WARN=y CONFIG_DEFAULT_TASK_STACKSIZE=8192 +CONFIG_DEV_SIMPLE_ADDRENV=y Review Comment: Done ########## boards/risc-v/qemu-rv/rv-virt/configs/knetnsh64/defconfig: ########## @@ -49,13 +49,13 @@ CONFIG_DEBUG_FULLOPT=y CONFIG_DEBUG_SYMBOLS=y CONFIG_DEV_ZERO=y CONFIG_DRIVERS_VIRTIO=y -CONFIG_DRIVERS_VIRTIO_MMIO_BASE=0x10001000 -CONFIG_DRIVERS_VIRTIO_MMIO_IRQ=26 -CONFIG_DRIVERS_VIRTIO_MMIO_NUM=8 -CONFIG_DRIVERS_VIRTIO_MMIO_REGSIZE=0x1000 +CONFIG_DRIVERS_VIRTIO_BLK=y +CONFIG_DRIVERS_VIRTIO_MMIO=y CONFIG_DRIVERS_VIRTIO_NET=y +CONFIG_DRIVERS_VIRTIO_RNG=y +CONFIG_DRIVERS_VIRTIO_SERIAL=y CONFIG_ELF=y -CONFIG_EXAMPLES_HELLO=m +CONFIG_EXAMPLES_HELLO=y Review Comment: Done ########## boards/risc-v/qemu-rv/rv-virt/configs/knetnsh64_smp/defconfig: ########## @@ -49,13 +49,13 @@ CONFIG_DEBUG_FULLOPT=y CONFIG_DEBUG_SYMBOLS=y CONFIG_DEV_ZERO=y CONFIG_DRIVERS_VIRTIO=y -CONFIG_DRIVERS_VIRTIO_MMIO_BASE=0x10001000 -CONFIG_DRIVERS_VIRTIO_MMIO_IRQ=26 -CONFIG_DRIVERS_VIRTIO_MMIO_NUM=8 -CONFIG_DRIVERS_VIRTIO_MMIO_REGSIZE=0x1000 +CONFIG_DRIVERS_VIRTIO_BLK=y +CONFIG_DRIVERS_VIRTIO_MMIO=y CONFIG_DRIVERS_VIRTIO_NET=y +CONFIG_DRIVERS_VIRTIO_RNG=y +CONFIG_DRIVERS_VIRTIO_SERIAL=y CONFIG_ELF=y -CONFIG_EXAMPLES_HELLO=m +CONFIG_EXAMPLES_HELLO=y Review Comment: Done ########## boards/risc-v/qemu-rv/rv-virt/configs/netnsh/defconfig: ########## @@ -35,13 +35,12 @@ CONFIG_DEBUG_SYMBOLS=y CONFIG_DEV_ZERO=y CONFIG_DRIVERS_VIRTIO=y CONFIG_DRIVERS_VIRTIO_BLK=y -CONFIG_DRIVERS_VIRTIO_MMIO_BASE=0x10001000 -CONFIG_DRIVERS_VIRTIO_MMIO_IRQ=28 -CONFIG_DRIVERS_VIRTIO_MMIO_NUM=8 -CONFIG_DRIVERS_VIRTIO_MMIO_REGSIZE=0x1000 +CONFIG_DRIVERS_VIRTIO_MMIO=y CONFIG_DRIVERS_VIRTIO_NET=y +CONFIG_DRIVERS_VIRTIO_RNG=y +CONFIG_DRIVERS_VIRTIO_SERIAL=y CONFIG_ELF=y -CONFIG_EXAMPLES_HELLO=m +CONFIG_EXAMPLES_HELLO=y Review Comment: Done ########## boards/risc-v/qemu-rv/rv-virt/configs/netnsh64/defconfig: ########## @@ -35,13 +35,12 @@ CONFIG_DEBUG_SYMBOLS=y CONFIG_DEV_ZERO=y CONFIG_DRIVERS_VIRTIO=y CONFIG_DRIVERS_VIRTIO_BLK=y -CONFIG_DRIVERS_VIRTIO_MMIO_BASE=0x10001000 -CONFIG_DRIVERS_VIRTIO_MMIO_IRQ=28 -CONFIG_DRIVERS_VIRTIO_MMIO_NUM=8 -CONFIG_DRIVERS_VIRTIO_MMIO_REGSIZE=0x1000 +CONFIG_DRIVERS_VIRTIO_MMIO=y CONFIG_DRIVERS_VIRTIO_NET=y +CONFIG_DRIVERS_VIRTIO_RNG=y +CONFIG_DRIVERS_VIRTIO_SERIAL=y CONFIG_ELF=y -CONFIG_EXAMPLES_HELLO=m +CONFIG_EXAMPLES_HELLO=y Review Comment: Done ########## boards/risc-v/qemu-rv/rv-virt/configs/netnsh64_smp/defconfig: ########## @@ -34,21 +34,22 @@ CONFIG_DEBUG_FULLOPT=y CONFIG_DEBUG_SYMBOLS=y CONFIG_DEV_ZERO=y CONFIG_DRIVERS_VIRTIO=y -CONFIG_DRIVERS_VIRTIO_MMIO_BASE=0x10001000 -CONFIG_DRIVERS_VIRTIO_MMIO_IRQ=28 -CONFIG_DRIVERS_VIRTIO_MMIO_NUM=8 -CONFIG_DRIVERS_VIRTIO_MMIO_REGSIZE=0x1000 +CONFIG_DRIVERS_VIRTIO_BLK=y +CONFIG_DRIVERS_VIRTIO_MMIO=y CONFIG_DRIVERS_VIRTIO_NET=y +CONFIG_DRIVERS_VIRTIO_RNG=y +CONFIG_DRIVERS_VIRTIO_SERIAL=y CONFIG_ELF=y -CONFIG_EXAMPLES_HELLO=m +CONFIG_EXAMPLES_HELLO=y Review Comment: Done ########## boards/risc-v/qemu-rv/rv-virt/configs/netnsh_smp/defconfig: ########## @@ -34,21 +34,22 @@ CONFIG_DEBUG_FULLOPT=y CONFIG_DEBUG_SYMBOLS=y CONFIG_DEV_ZERO=y CONFIG_DRIVERS_VIRTIO=y -CONFIG_DRIVERS_VIRTIO_MMIO_BASE=0x10001000 -CONFIG_DRIVERS_VIRTIO_MMIO_IRQ=28 -CONFIG_DRIVERS_VIRTIO_MMIO_NUM=8 -CONFIG_DRIVERS_VIRTIO_MMIO_REGSIZE=0x1000 +CONFIG_DRIVERS_VIRTIO_BLK=y +CONFIG_DRIVERS_VIRTIO_MMIO=y CONFIG_DRIVERS_VIRTIO_NET=y +CONFIG_DRIVERS_VIRTIO_RNG=y +CONFIG_DRIVERS_VIRTIO_SERIAL=y CONFIG_ELF=y -CONFIG_EXAMPLES_HELLO=m +CONFIG_EXAMPLES_HELLO=y Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
