xiaoxiang781216 commented on code in PR #9647:
URL: https://github.com/apache/nuttx/pull/9647#discussion_r1246796735
##########
include/nuttx/net/usrsock.h:
##########
@@ -83,6 +83,7 @@ enum usrsock_request_types_e
USRSOCK_REQUEST_ACCEPT,
USRSOCK_REQUEST_IOCTL,
USRSOCK_REQUEST_SHUTDOWN,
+ USRSOCK_REQUEST_AVAILABLE,
Review Comment:
why not reuse USRSOCK_REQUEST_SOCKET? usersock server could return a special
error code to continue the normal creation process.
##########
net/usrsock/Kconfig:
##########
@@ -76,12 +76,10 @@ config NET_USRSOCK_NPOLLWAITERS
config NET_USRSOCK_UDP
bool "User-space daemon provides UDP sockets"
default n
- select NET_UDP_NO_STACK
Review Comment:
why remove the selection? can we disable the selection in defconfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
