xiaoxiang781216 commented on PR #9774: URL: https://github.com/apache/nuttx/pull/9774#issuecomment-1630573906
> That's not true POSIX defines it as an `arithmetic type`; vendor specific (one of the reasons it belongs to `<sys/types.h>` and should be declared there not in `<time.h>` as defined per POSIX specs) ; some use an `enum, others int, unsigned int etc...`, `uint8_t` was perfectly fine and it saves bytes. > It isn't true, clock_id may hold the pid_t. Please see the follow patch: https://github.com/apache/nuttx/pull/9708 https://github.com/apache/nuttx/pull/9701 > What is conforming to POSIX: is to be declared in `<sys/types.h>` e.g system availability, `uint8_t` is a perfectly valid `arithmetic type` usually ranging from 0x00 to 0xFF, so well enough until the next millenium. since pid_t is int, so it's reasonable to typedef clock_id to int. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
