xiaoxiang781216 commented on PR #9863: URL: https://github.com/apache/nuttx/pull/9863#issuecomment-1648373675
> > @Ouss4 , @gustavonihei I think you both wrote/worked this/in file (arch/xtensa/src/common/xtensa_tcbinfo.c) > > The point that @xiaoxiang781216 is making is that the are just data definitions in a static library. It doesn't need to be built conditionally because it will not be drawn into the build from the library if it is not referenced by anything. Nothing else is changed. > > There are a few additional changes here that don't related to the title or description. > > * Corrects a register name These changes are moved to https://github.com/apache/nuttx/pull/9859. > * Removes TCB_STACK_OFF and TCB_STACK_SIZE_OFF (unused?) Good catch! it's fixed by https://github.com/apache/nuttx/pull/9878. Both fields are used to support TRACE32 thread awareness debugging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
