pkarashchenko commented on code in PR #10070:
URL: https://github.com/apache/nuttx/pull/10070#discussion_r1284179936
##########
drivers/usbdev/rndis.c:
##########
@@ -2942,15 +2942,21 @@ static void usbclass_uninitialize(FAR struct
usbdevclass_driver_s *classdev)
{
FAR struct rndis_driver_s *drvr = (FAR struct rndis_driver_s *)classdev;
FAR struct rndis_alloc_s *alloc = (FAR struct rndis_alloc_s *)drvr->dev;
-
+ if (!alloc->dev.registered)
+ {
+#ifdef CONFIG_USBADB_COMPOSITE
+ kmm_free(alloc);
+#endif
+ return;
+ }
if (drvr->dev->registered)
{
netdev_unregister(&drvr->dev->netdev);
drvr->dev->registered = false;
- }
- else
- {
+#ifndef CONFIG_RNDIS_COMPOSITE
kmm_free(alloc);
+#endif
+ return;
Review Comment:
`return;` is not needed here
##########
drivers/usbdev/rndis.c:
##########
@@ -2942,15 +2942,21 @@ static void usbclass_uninitialize(FAR struct
usbdevclass_driver_s *classdev)
{
FAR struct rndis_driver_s *drvr = (FAR struct rndis_driver_s *)classdev;
FAR struct rndis_alloc_s *alloc = (FAR struct rndis_alloc_s *)drvr->dev;
-
+ if (!alloc->dev.registered)
+ {
+#ifdef CONFIG_USBADB_COMPOSITE
+ kmm_free(alloc);
+#endif
+ return;
+ }
if (drvr->dev->registered)
Review Comment:
Can do `else if` and remove `return;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
