raiden00pl commented on code in PR #10092:
URL: https://github.com/apache/nuttx/pull/10092#discussion_r1285176464
##########
arch/arm/src/nrf52/nrf52_i2c.c:
##########
@@ -373,7 +374,9 @@ static int nrf52_i2c_transfer(struct i2c_master_s *dev,
/* Write number of bytes in TXD buffer */
regval = priv->dcnt;
- nrf52_i2c_putreg(priv, NRF52_TWIM_TXMAXCNT_OFFSET, regval);
+ nrf52_i2c_putreg(priv, NRF52_TWIM_TXDMAXCNT_OFFSET, regval);
+
+ nxsig_usleep(1);
Review Comment:
why is sleep needed here ? is this some common nrf52 issue or application
specific ?
##########
boards/arm/nrf52/arduino-nano-33ble/CMakeLists.txt:
##########
@@ -0,0 +1,21 @@
+#
##############################################################################
Review Comment:
I don't see `arduino-nano-33ble/src/CMakeList.txt` so there is no point to
include this file. Please provide `arduino-nano-33ble/src/CMakeList.txt` or we
can remove arduino-nano-33ble/CMakeList.txt from this PR
##########
boards/arm/nrf52/arduino-nano-33ble/scripts/flash_config.ld:
##########
@@ -0,0 +1,106 @@
+/****************************************************************************
+ * boards/arm/nrf52/arduino-nano-33ble/scripts/flash_config.ld
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+MEMORY
+{
+ progmem (rx) : ORIGIN = 0x00010000, LENGTH = 960K
Review Comment:
is there any built-in bootloader? if so, maybe we should configure the
bootloader presence with with Kconfig ?
##########
arch/arm/src/nrf52/hardware/nrf52_twi.h:
##########
@@ -154,7 +154,7 @@
#define TWIM_FREQUENCY_100KBPS (0x01980000) /* 100 kbps */
#define TWIM_FREQUENCY_250KBPS (0x04000000) /* 250 kbps */
-#define TWIM_FREQUENCY_400KBPS (0x06400000) /* 400 kbps */
+#define TWIM_FREQUENCY_400KBPS (0x06200000) /* 400 kbps */
Review Comment:
this should be configurable form Kconfig like other workarounds, eg here:
https://github.com/apache/nuttx/blob/c1ddfcfa839d9e75428f45e79e5c564122322e08/arch/arm/src/nrf52/Kconfig#L680
I guess we can set `default y` for this. Interestingly, some I2C devices
seem tolerant to this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
