zyfeier commented on PR #10084: URL: https://github.com/apache/nuttx/pull/10084#issuecomment-1667123474
> I don't think coupling USB device class logic with composite device logic is a good idea. These are two separate functionalities, and device class logic should not depend on composite logic. > > Why not move the common USB device logic to a separate file, private for `drivers/usbdev` e.g. `usbdev_common.c/usbdev_common.h` ? Hi, raiden00pl: I initially extracted the common code, but found that it was almost identical to the code in composite.c. Additionally, the main difference between composite and non-composite devices is that composite devices support multiple functions, which can be distinguished through configuration. Therefore, I felt that it was more appropriate to directly use composite.c. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
