lupyuen commented on code in PR #10193:
URL: https://github.com/apache/nuttx/pull/10193#discussion_r1292180530


##########
arch/arm64/include/a64/chip.h:
##########
@@ -39,21 +39,24 @@
 
 /* Allwinner A64 Generic Interrupt Controller v2: Distributor and Redist */
 
-#define CONFIG_GICD_BASE          0x1C81000
-#define CONFIG_GICR_BASE          0x1C82000
+#define CONFIG_GICD_BASE          0x8000000
+#define CONFIG_GICR_BASE          0x80a0000
+#define CONFIG_GICR_OFFSET        0x20000

Review Comment:
   According to the [Linux Device Tree for 
RK3399](https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/rockchip/rk3399.dtsi#L549-L553):
   - GICD = 0xfee00000
   - GICR = 0xfef00000
   
   But I'm not sure what's 
[CONFIG_GICR_OFFSET](https://github.com/apache/nuttx/blob/master/arch/arm64/src/common/arm64_gicv3.c#L786-L793).
 
   
   Maybe we stick with the current value and test whether [UART 
Interrupts](https://lupyuen.github.io/articles/serial#uart-with-interrupts) are 
OK?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to