xiaoxiang781216 commented on code in PR #10092:
URL: https://github.com/apache/nuttx/pull/10092#discussion_r1292692828
##########
arch/Kconfig:
##########
@@ -118,6 +118,7 @@ config ARCH_SIM
select SERIAL_CONSOLE
select SERIAL_IFLOWCONTROL
select SCHED_HPWORK
+ select ARCH_HAVE_CPUINFO
Review Comment:
rebase to the last master to remove this change
##########
arch/arm/src/nrf52/hardware/nrf52_twi.h:
##########
@@ -154,7 +154,11 @@
#define TWIM_FREQUENCY_100KBPS (0x01980000) /* 100 kbps */
#define TWIM_FREQUENCY_250KBPS (0x04000000) /* 250 kbps */
+#ifdef NRF52_I2C_MASTER_WORKAROUND_400KBPS_TIMING
+#define TWIM_FREQUENCY_400KBPS (0x06200000) /* 400 kbps */
Review Comment:
```suggestion
# define TWIM_FREQUENCY_400KBPS (0x06200000) /* 400 kbps */
```
##########
arch/arm/src/nrf52/hardware/nrf52_twi.h:
##########
@@ -154,7 +154,11 @@
#define TWIM_FREQUENCY_100KBPS (0x01980000) /* 100 kbps */
#define TWIM_FREQUENCY_250KBPS (0x04000000) /* 250 kbps */
+#ifdef NRF52_I2C_MASTER_WORKAROUND_400KBPS_TIMING
+#define TWIM_FREQUENCY_400KBPS (0x06200000) /* 400 kbps */
+#else
#define TWIM_FREQUENCY_400KBPS (0x06400000) /* 400 kbps */
Review Comment:
```suggestion
# define TWIM_FREQUENCY_400KBPS (0x06400000) /* 400 kbps */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
