xiaoxiang781216 commented on code in PR #1977: URL: https://github.com/apache/nuttx-apps/pull/1977#discussion_r1299530067
########## crypto/mbedtls/include/aes_alt.h: ########## @@ -0,0 +1,48 @@ +/**************************************************************************** + * apps/crypto/mbedtls/include/aes_alt.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + ****************************************************************************/ + +#ifndef __APPS_CRYPTO_MBEDTLS_INCLUDE_AES_ALT_H +#define __APPS_CRYPTO_MBEDTLS_INCLUDE_AES_ALT_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include "dev_alt.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define ECB_BLOCK_SIZE 16 +#define MAX_KEY_SIZE 36 +#define MAX_IV_SIZE 16 +#define NONCE_LENGTH 4 + +typedef struct mbedtls_aes_context +{ + cryptodev_context_t dev; + unsigned char key[MAX_KEY_SIZE]; + unsigned char iv[MAX_IV_SIZE]; Review Comment: change iv to stack variable if needed ########## crypto/mbedtls/include/aes_alt.h: ########## @@ -0,0 +1,48 @@ +/**************************************************************************** + * apps/crypto/mbedtls/include/aes_alt.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + ****************************************************************************/ + +#ifndef __APPS_CRYPTO_MBEDTLS_INCLUDE_AES_ALT_H +#define __APPS_CRYPTO_MBEDTLS_INCLUDE_AES_ALT_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include "dev_alt.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define ECB_BLOCK_SIZE 16 Review Comment: move all macro except MAX_KEY_SIZE to source file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
