xuxin930 commented on code in PR #10379:
URL: https://github.com/apache/nuttx/pull/10379#discussion_r1302976311
##########
libs/libxx/libcxx.cmake:
##########
@@ -18,10 +18,28 @@
#
#
##############################################################################
-if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/libcxx/.git)
+if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/libcxx)
set(LIBCXX_VERSION 12.0.0)
+ set(LIBCXX_PATCH_COMMAND
+ patch -p0 -d ${CMAKE_CURRENT_LIST_DIR} <
+ ${CMAKE_CURRENT_LIST_DIR}/0001-Remove-the-locale-fallback-for-NuttX.patch
Review Comment:
@anchao
there is a code-style problem here.
if cmake-format is used, the statement will be modified to :
```cmake
set(LIBCXX_PATCH_COMMAND
patch
-p0
-d
${CMAKE_CURRENT_LIST_DIR}
<
....
)
```
readability gets worse.
should we also use whitelist for cmake files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
