xiaoxiang781216 commented on code in PR #1990: URL: https://github.com/apache/nuttx-apps/pull/1990#discussion_r1303222648
########## system/libuv/Makefile: ########## @@ -52,8 +52,11 @@ CFLAGS += -Wno-shadow CFLAGS += -DDEF_THREADPOOL_SIZE=CONFIG_LIBUV_THREADPOOL_SIZE CFLAGS += -DDEF_THREADPOOL_STACKSIZE=CONFIG_LIBUV_THREAD_STACKSIZE -GCCVER = $(shell $(CC) --version | grep gcc | sed -r 's/.* ([0-9]+\.[0-9]+\.[0-9]+).*/\1/') -ifeq ($(GCCVER),12.2.1) +ifeq ($(GCCVER),) + GCCVER = $(shell $(CC) --version | grep gcc | sed -r 's/.* ([0-9]+\.[0-9]+).*/\1/' | cut -d'.' -f1) Review Comment: let's merge this patch to unblock ci. @anchao please create a new patch if @pkarashchenko 's suggestion looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
