hartmannathan commented on PR #10378: URL: https://github.com/apache/nuttx/pull/10378#issuecomment-1690780613
> Theses are the warnings about too long line that I don't know how to proceed to keep a code readable :) `nxstyle` (the program that checks for too-long lines and other code style rules) looks at the length of the `/*************` separators in the file and uses that to decide the longest allowed line. Note, though, that while it requires lines of **_code_** to be shorter than the row of asterisks, it allows some leeway for lines of `#define`s: these can be longer than the asterisks as long as the definition starts before the end of the asterisks. This exception is included exactly for the purpose of keeping defines readable! An example might make it more clear. See: https://github.com/apache/nuttx/blob/master/arch/arm/src/tiva/hardware/tm4c/tm4c_memorymap.h Notice how the lines of defines are longer than the asterisks. However, this is accepted by `nxstyle` because the definition begins before the asterisks end. In your file, the definitions that `nxstyle` complains about begin after the asterisks. A workaround is to add more asterisks. You can use `tools/nxstyle` in the NuttX repo to test your file. That way, you don't have to keep force-pushing and waiting for the lengthy checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
