xiaoxiang781216 commented on code in PR #1998:
URL: https://github.com/apache/nuttx-apps/pull/1998#discussion_r1306605834
##########
crypto/mbedtls/Kconfig:
##########
@@ -61,68 +63,64 @@ config MBEDTLS_ECP_RESTARTABLE
config MBEDTLS_SELF_TEST
bool "Enable the checkup functions (*_self_test)."
- default y
+ default n
config MBEDTLS_SSL_DTLS_CLIENT_PORT_REUSE
bool "Enable server-side support for clients that reconnect from the
same port."
- default n
+ default y
config MBEDTLS_BLOWFISH_C
bool "Enable the Blowfish block cipher."
- default n
+ default y
Review Comment:
why enable blowfish by the default
##########
crypto/mbedtls/Kconfig:
##########
@@ -61,68 +63,64 @@ config MBEDTLS_ECP_RESTARTABLE
config MBEDTLS_SELF_TEST
bool "Enable the checkup functions (*_self_test)."
- default y
+ default n
config MBEDTLS_SSL_DTLS_CLIENT_PORT_REUSE
bool "Enable server-side support for clients that reconnect from the
same port."
- default n
+ default y
config MBEDTLS_BLOWFISH_C
bool "Enable the Blowfish block cipher."
- default n
+ default y
config MBEDTLS_CAMELLIA_C
bool "Enable the Camellia block cipher."
- default n
-
-config MBEDTLS_CERTS_C
- bool "Enable the test certificates."
- default n
+ default y
config MBEDTLS_PADLOCK_C
bool "Enable VIA Padlock support on x86."
- default n
+ default y if !MBEDTLS_AES_ALT
config MBEDTLS_TIMING_C
bool "Enable the semi-portable timing interface."
default y
config MBEDTLS_SSL_KEEP_PEER_CERTIFICATE
bool "Enable the availability of the API mbedtls_ssl_get_peer_cert()
giving access to the peer's certificate after completion of the handshake."
- default n
Review Comment:
why change the default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
