Siviuze commented on code in PR #10398:
URL: https://github.com/apache/nuttx/pull/10398#discussion_r1307486348
##########
tools/mkexport.sh:
##########
@@ -265,8 +292,19 @@ if [ "X${USRONLY}" != "Xy" ]; then
echo "LDENDGROUP = ${LDENDGROUP}" >>"${EXPORTDIR}/scripts/Make.defs"
echo "LDFLAGS = ${LDFLAGS}" >>"${EXPORTDIR}/scripts/Make.defs"
echo "LDSTARTGROUP = ${LDSTARTGROUP}" >>"${EXPORTDIR}/scripts/Make.defs"
+
+ echo "set(EXTRA_LIBS \"${EXTRA_LIBS}\")"
>>"${EXPORTDIR}/scripts/target.cmake"
+ echo "set(EXTRA_OBJS \"${EXTRA_OBJS}\")"
>>"${EXPORTDIR}/scripts/target.cmake"
+ echo "set(HEAD_OBJ \"${HEAD_OBJ}\")"
>>"${EXPORTDIR}/scripts/target.cmake"
+ echo "set(LDENDGROUP \"${LDENDGROUP}\")"
>>"${EXPORTDIR}/scripts/target.cmake"
+ echo "set(LDFLAGS \"${LDFLAGS}\")"
>>"${EXPORTDIR}/scripts/target.cmake"
+ echo "set(LDSTARTGROUP \"${LDSTARTGROUP}\")"
>>"${EXPORTDIR}/scripts/target.cmake"
fi
+# Copy the CMake toolchain file
+
+cp "${TOPDIR}/tools/toolchainfile.cmake.export"
"${EXPORTDIR}/scripts/toolchainfile.cmake"
Review Comment:
Standard suffix for CMake toolchain files is .cmake. I choose to add
'export' suffix in the tool folder to emphasis that the file is related to the
export step and is not usable as-is (I didn't find a place for exported files).
I can name it .cmake if you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
