xiaoxiang781216 commented on PR #10565: URL: https://github.com/apache/nuttx/pull/10565#issuecomment-1713828734
> > @danielappiagyei-bc but the change from 'this' to 'self' lose? > > I only renamed the 'this' function argument to 'self' [here](https://github.com/apache/nuttx/pull/10565/files#diff-2dd8bd975a0b4fe946a837961405b253a447eb9822e8e9a4b43359aeea2b0188L73) in `include/nuttx/streams.h` since that's the only `.h` file I found it in. It's still used in several `.c` files such as https://github.com/apache/nuttx/blob/master/drivers/segger/stream_rtt.c#L87 but I left those alone since only the `.h` files need to be compatible with C++ compilers when you `#include` them. However, I can rename these remaining usages as well if you would like it's better to unify the naming and avoid the user copy public/this to other places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
