xiaoxiang781216 commented on PR #10600:
URL: https://github.com/apache/nuttx/pull/10600#issuecomment-1715749307

   four errors still exist:
   https://github.com/spiriou/microADB/pull/38 fix this error:
   ```
   Error: microADB/hal/hal_uv.c:32:38: error: a function declaration without a 
prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
   adb_context_t* adb_hal_create_context() {
   ```
   The latest libuv fix all following warning:
   ```
   make[2]: *** [/Users/runner/work/nuttx/nuttx/sources/apps/system/adb_all] 
Error 2
   Error: libuv/test/runner.c:80:7: error: variable 'passed' set but not used 
[-Werror,-Wunused-but-set-variable]
     int passed;
         ^
   Error: libuv/test/runner.c:82:7: error: variable 'skipped' set but not used 
[-Werror,-Wunused-but-set-variable]
     int skipped;
         ^
   2 errors generated.
   make[3]: *** 
[runner.c.Users.runner.work.nuttx.nuttx.sources.apps.system.libuv.o] Error 1
   Error: libuv/test/test-env-vars.c:33:30: error: variable 'found_win_special' 
set but not used [-Werror,-Wunused-but-set-variable]
     int i, r, envcount, found, found_win_special;
                                ^
   1 error generated.
   make[3]: *** 
[test-env-vars.c.Users.runner.work.nuttx.nuttx.sources.apps.system.libuv.o] 
Error 1
   Error: libuv/test/test-ipc.c:838:44: error: a function declaration without a 
prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
   static unsigned int write_until_data_queued() {
                                              ^
                                               void
   Error: libuv/test/test-ipc.c:857:34: error: a function declaration without a 
prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
   static void send_handle_and_close() {
   ```
   @no1wudi will update libuv to fix this problem.
   https://github.com/svaarala/duktape/pull/2545 fix this problem:
   ```
   Error: duktape/src-noline/duktape.c:73222:13: error: variable 'num_stmts' 
set but not used [-Werror,-Wunused-but-set-variable]
                   duk_int_t num_stmts;
   ```
   @no1wudi please apply the patch after downloading before 
https://github.com/svaarala/duktape/pull/2545 get merged.
   libcxx is the toughest compiler error:
   ```
   Error: libcxx/src/filesystem/directory_iterator.cpp:189:57: error: 
unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
                                                   __root_(move(other.__root_)),
                                                           ^
                                                           std::
   Error: libcxx/src/filesystem/directory_iterator.cpp:190:58: error: 
unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
                                                   
__entry_(move(other.__entry_)) {
                                                            ^
                                                            std::
   Error: libcxx/src/filesystem/directory_iterator.cpp:272:17: error: 
unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
       path root = move(__imp_->__root_);
                   ^
                   std::
   Error: libcxx/src/filesystem/directory_iterator.cpp:306:25: error: 
unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
     __imp_->__stack_.push(move(new_s));
                           ^
                           std::
   Error: libcxx/src/filesystem/directory_iterator.cpp:360:17: error: 
unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
       path root = move(stack.top().__root_);
                   ^
                   std::
   Error: libcxx/src/filesystem/directory_iterator.cpp:394:29: error: 
unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
         __imp_->__stack_.push(move(new_it));
                               ^
                               std::
   Error: libcxx/src/filesystem/directory_iterator.cpp:405:21: error: 
unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
         path at_ent = move(curr_it.__entry_.__p_);
                       ^
                       std::
   ```
   the error look like libcxx version is too old to fail to compil with the new 
clang, so we need:
   
   1. Fix issue reported here: https://github.com/apache/nuttx/issues/10594
   2. Upgrade libcxx by https://github.com/apache/nuttx/pull/8244
   
   @pkarashchenko could you help fix riscv toolchain issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to