gregory-nutt commented on code in PR #10602:
URL: https://github.com/apache/nuttx/pull/10602#discussion_r1324969904


##########
include/stdio.h:
##########
@@ -244,6 +244,11 @@ int    dprintf(int fd, FAR const IPTR char *fmt, ...) 
printf_like(2, 3);
 int    vdprintf(int fd, FAR const IPTR char *fmt, va_list ap)
        printf_like(2, 0);
 
+/* Custom stream operation fopencookie. */
+
+FAR FILE *fopencookie(FAR void *cookie, FAR const char *mode,
+                      cookie_io_functions_t io_funcs);
+

Review Comment:
   It is prohibited to add non-standard interfaces to the OS.  We are purely 
standards based and non-standard, ad hoc OS interfaces are generally prohibited.
   
   Hmm... I see that Linux does support this interface:  
https://man7.org/linux/man-pages/man3/fopencookie.3.html .. Is that a 
sufficient justification?  The man page lists only GNU as the justification for 
the interface.  That would not have been accepted in the past, but an objective 
to have Linux compatibility has crept into our project mindset recently.  So 
maybe this is okay for that reason.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to