trns1997 commented on code in PR #10553: URL: https://github.com/apache/nuttx/pull/10553#discussion_r1325408922
########## arch/arm/src/a1x/a1x_lowputc.c: ########## @@ -27,13 +27,15 @@ #include <stdint.h> #include <arch/irq.h> -#include <arch/board/board.h> #include "arm_internal.h" #include "a1x_config.h" -#include "hardware/a1x_uart.h" #include "a1x_pio.h" +#include "hardware/a1x_uart.h" + +#include <arch/board/board.h> Review Comment: it looked more consistent, where u have nuttx specific imports first, then hardware includes then board.h. But i guess i could just revert it as it is unnecessary, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
