royfengsss commented on code in PR #10626: URL: https://github.com/apache/nuttx/pull/10626#discussion_r1326663196
########## libs/libm/newlib/Make.defs: ########## @@ -18,21 +18,31 @@ # ############################################################################ -NEWLIB_VERSION=4.3.0.20230120 +ifeq ($(CONFIG_LIBM_USE_NEWLIB_ESP32),y) + NEWLIB_VERSION=esp-4.1.0_20230425 + NEWLIB_BASENAME=newlib-esp32 + NEWLIB_URL_BASE=https://github.com/espressif/newlib-esp32/archive + NEWLIB_TARBALL=$(NEWLIB_VERSION).tar.gz +else + NEWLIB_VERSION=4.3.0.20230120 Review Comment: > I mean, do we know what is the gap between 4.1.0 from `sourceware.org` vs espressif one? The mainly changes in newlib-esp32 is for RISCV. The change for Xtensa is not so much. as far as I can find, sqrt() and fmod() are different. I also can see some changes in sourceware.org newlib v4.3.0 were not picked into current newllib-esp32. We hope Espressif can bump the source to the latest soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
