raiden00pl opened a new issue, #10644:
URL: https://github.com/apache/nuttx/issues/10644

   I've spent some time playing with the new sensor framework, and I'm much 
less skeptical about this approach (previous discussion here 
https://github.com/apache/nuttx/pull/10077). It seems to me that with some 
changes, it can be a good universal solution. Unfortunately, the lack of 
documentation causes some misunderstanding. Most information about framework 
can be found in the discussion under https://github.com/apache/nuttx/pull/2039 
and https://github.com/apache/nuttx/pull/2215. Somehow I missed this before :)
   
   Some ideas for improvement from my side:
   
   1. We should stop referring to this sensor framework as `uorb`. `uorb` is 
optional and is part of the apps. Referring to `uorb` on the kernel side gives 
the false impression that uorb is required.
      
   2. Make sensor register path configurable. Now it is `/dev/uorb` (changed in 
 c4bed9eae9037297b3f8de6a3547e8ca6361b933) but as `uorb` is 
application-specific property, this should be configurable.
      
   3. Add options to disable some framework functionality. This can save memory 
on small systems. For example, disabling polling logic and relying only on the 
`fetch` interface saves some space and gives the user full control over sensor 
sampling. Another thing is `timestamp`; in many cases, timestamp doesn't matter 
for user.
      
   4. The biggest problem I see now is forcing the user to use `float`. This is 
not the best solution for applications without FPU (e.g. CM0 which are often 
used in sensor nodes). What if we made the sensor data type configurable? It 
would be nice if we had an interface that return data in RAW format, but this 
may unnecessarily complicate the framework. Support for fixedmath type seems to 
be a good compromise (`b16_t` ?).
   
   If there is consent to these changes, I can take care of them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to