pkarashchenko commented on code in PR #10661:
URL: https://github.com/apache/nuttx/pull/10661#discussion_r1328395325
##########
net/rpmsg/rpmsg_sockif.c:
##########
@@ -402,7 +402,7 @@ static inline void rpmsg_socket_destroy_ept(
if (conn->ept.rdev)
{
- if (conn->backlog)
+ if (conn->backlog > 0)
Review Comment:
yeah. that is why I comment mostly at each PR I review that comparison
condition should be specified and `if (a)` should be used only when `a` is
`bool`. I had to investigate many bugs like this that could be avoided by using
an explicit comparison condition. Anyway LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
