raiden00pl commented on code in PR #10826: URL: https://github.com/apache/nuttx/pull/10826#discussion_r1340419670
########## arch/arm/src/nrf52/nrf52_start.c: ########## @@ -203,6 +203,10 @@ void __start(void) nrf52_enable_profile(true); #endif +#if defined(CONFIG_SCHED_IRQMONITOR) || defined(CONFIG_SEGGER_SYSVIEW) Review Comment: I think we still need an additional flag indicating that we have to include `up_perf` support. With https://github.com/apache/nuttx/pull/10828 we can select if we want arch specific `up_perf` with `CONFIG_ARCH_PERF_EVENTS=y` or `drivers/timers/arch_timer.c` implementation when `CONFIG_ARCH_PERF_EVENTS=n`. If we set `CONFIG_ARCH_PERF_EVENTS` default to n and we make including the code dependent on it, then we lose the ability to choose the `drivers/timers/arch_timer.c` implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
