xiaoxiang781216 commented on code in PR #10834: URL: https://github.com/apache/nuttx/pull/10834#discussion_r1341279216
########## sched/clock/clock_perf.c: ########## @@ -0,0 +1,176 @@ +/**************************************************************************** + * sched/clock/clock_perf.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdint.h> + +#include <nuttx/clock.h> +#include <nuttx/arch.h> +#include <nuttx/wdog.h> + +#if defined(CONFIG_PERF_OVERFLOW_CORRECTION) && ULONG_MAX != UINT64_MAX + +/**************************************************************************** + * Private Types + ****************************************************************************/ + +struct perf_s +{ + struct wdog_s wdog; + unsigned long last; + unsigned long overflow; +}; + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static struct perf_s g_perf; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * perf_update + ****************************************************************************/ + +static void perf_update(wdparm_t arg) +{ + clock_t tick = (clock_t)LONG_MAX * TICK_PER_SEC / up_perf_getfreq(); + + perf_gettime(); + wd_start((FAR struct wdog_s *)arg, tick, perf_update, arg); +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * perf_init + ****************************************************************************/ + +void perf_init(void) +{ + FAR struct perf_s *perf = &g_perf; + clock_t tick = (clock_t)LONG_MAX * TICK_PER_SEC / up_perf_getfreq(); + + perf->last = up_perf_gettime(); + + /* Periodic check for overflow */ + + wd_start(&perf->wdog, tick, perf_update, (wdparm_t)perf); +} + +/**************************************************************************** + * perf_gettime + ****************************************************************************/ + +clock_t perf_gettime(void) +{ + FAR struct perf_s *perf = &g_perf; + unsigned long now = up_perf_gettime(); + + /* Check if overflow */ + + if (now < perf->last) + { + perf->overflow++; + } + + perf->last = now; + return (clock_t)now | (clock_t)perf->overflow << 32; +} + +/**************************************************************************** + * perf_convert + ****************************************************************************/ + +void perf_convert(clock_t elapsed, FAR struct timespec *ts) +{ + unsigned long freq = up_perf_getfreq(); + + ts->tv_sec = elapsed / freq; + elapsed -= ts->tv_sec * freq; + ts->tv_nsec = NSEC_PER_SEC * elapsed / freq; +} + +#elif defined(CONFIG_ALARM_ARCH) || defined (CONFIG_TIMER_ARCH) || \ + defined(CONFIG_ARCH_PERF_EVENTS) + +/**************************************************************************** + * perf_init + ****************************************************************************/ + +void perf_init(void) +{ +} Review Comment: All are possible, since you are refining arch perf specific code, it's better to leave this issue until you come up a good solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
