xiaoxiang781216 commented on code in PR #10905: URL: https://github.com/apache/nuttx/pull/10905#discussion_r1358347477
########## arch/sim/src/sim/posix/sim_hostmisc.c: ########## @@ -90,10 +90,10 @@ void host_abort(int status) int host_backtrace(void** array, int size) { -#ifdef CONFIG_WINDOWS_CYGWIN - return 0; -#else +#ifdef CONFIG_SIM_GLIBC_PLATFORM Review Comment: it's better change to: ``` #if __has_include(<execinfo.h>) #endif ``` so, you don't need change it from defconfig for non glibc platform. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org