xiaoxiang781216 commented on code in PR #11169: URL: https://github.com/apache/nuttx/pull/11169#discussion_r1390326806
########## boards/arm/stm32/stm32f401rc-rs485/include/board.h: ########## @@ -335,22 +334,26 @@ extern "C" /* LEDs * - * The Nucleo F401RE and F411RE boards provide a single user LED, LD2. LD2 - * is the green LED connected to Arduino signal D13 corresponding to MCU I/O - * PA5 (pin 21) or PB13 (pin 34) depending on the STM32 target. - * + * The STM32F401RC-RS485 boards provide 4 blue user LEDs. LD1, LD2, LD3 + * and LD4 that are connected to MCU I/O pins PC0, PC1, PC2 and PC3. * - When the I/O is HIGH value, the LED is on. * - When the I/O is LOW, the LED is off. */ /* LED index values for use with board_userled() */ -#define BOARD_LD2 0 -#define BOARD_NLEDS 1 +#define BOARD_LD1 0 +#define BOARD_LD2 1 +#define BOARD_LD3 2 +#define BOARD_LD4 3 +#define BOARD_NLEDS 4 /* LED bits for use with board_userled_all() */ -#define BOARD_LD2_BIT (1 << BOARD_LD2) +#define BOARD_LED1_BIT (1 << BOARD_LD1) Review Comment: align `(1 << BOARD_LD1)` with line 349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
